aweisberg commented on code in PR #2049:
URL: https://github.com/apache/cassandra/pull/2049#discussion_r1063719879
##########
src/java/org/apache/cassandra/cql3/conditions/ColumnCondition.java:
##########
@@ -730,6 +1005,37 @@ public String toString()
{
return ToStringBuilder.reflectionToString(this,
ToStringStyle.SHORT_PREFIX_STYLE);
}
+
+ @Override
+ public BoundKind kind()
+ {
+ return BoundKind.MULTI_CELL_UDT;
+ }
+
+ private static final BoundSerializer<MultiCellUdtBound> serializer =
new BoundSerializer<MultiCellUdtBound>()
+ {
+ @Override
+ public void serialize(MultiCellUdtBound bound, DataOutputPlus out,
int version) throws IOException
+ {
+ serializeList(bound.values, out, version,
vintNullableSerializer);
+ out.writeUnsignedVInt(bound.protocolVersion.asInt());
+ }
+
+ @Override
+ public MultiCellUdtBound deserialize(DataInputPlus in, int
version, ColumnMetadata column, Operator operator) throws IOException
+ {
+ List<ByteBuffer> values = deserializeList(in, version,
vintNullableSerializer);
+ int protocolVersion = checkedCast(in.readUnsignedVInt());
+ // Does decode actually do what we want?
Review Comment:
Protocol version is null for user type. I could remove this and pass null
and it would continue to work and might be slightly clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
