dcapwell commented on code in PR #2066:
URL: https://github.com/apache/cassandra/pull/2066#discussion_r1065185023
##########
src/java/org/apache/cassandra/streaming/StreamingState.java:
##########
@@ -357,41 +333,9 @@ public static String columns()
" files_sent bigint, \n";
}
- public static Sessions create(Collection<SessionInfo> sessions)
- {
- long bytesToReceive = 0;
- long bytesReceived = 0;
- long filesToReceive = 0;
- long filesReceived = 0;
- long bytesToSend = 0;
- long bytesSent = 0;
- long filesToSend = 0;
- long filesSent = 0;
- for (SessionInfo session : sessions)
- {
- bytesToReceive += session.getTotalSizeToReceive();
- bytesReceived += session.getTotalSizeReceived();
-
- filesToReceive += session.getTotalFilesToReceive();
- filesReceived += session.getTotalFilesReceived();
-
- bytesToSend += session.getTotalSizeToSend();
- bytesSent += session.getTotalSizeSent();
-
- filesToSend += session.getTotalFilesToSend();
- filesSent += session.getTotalFilesSent();
- }
- if (0 == bytesToReceive && 0 == bytesReceived && 0 ==
filesToReceive && 0 == filesReceived && 0 == bytesToSend && 0 == bytesSent && 0
== filesToSend && 0 == filesSent)
- return EMPTY;
- return new Sessions(bytesToReceive, bytesReceived,
- bytesToSend, bytesSent,
- filesToReceive, filesReceived,
- filesToSend, filesSent);
- }
-
public boolean isEmpty()
{
- return this == EMPTY;
+ return bytesToReceive == 0 && bytesToSend == 0 && filesToReceive
== 0 && filesToSend == 0;
Review Comment:
if the stream has no work to do, this is `empty` which will not populate the
data in the vtable; so `null` rather than `0`. We "could" solve this but think
the vtable having `null` is fine in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
