maedhroz commented on code in PR #2049:
URL: https://github.com/apache/cassandra/pull/2049#discussion_r1066434045
##########
src/java/org/apache/cassandra/cql3/conditions/ColumnCondition.java:
##########
@@ -257,6 +315,55 @@ else if (otherValue == null)
}
return operator.isSatisfiedBy(type, otherValue, value);
}
+
+ void checkForUnsetValues(List<ByteBuffer> values)
Review Comment:
> It's a little easier to find out the unset value is unset when the bound
is constructed rather than later when it is applied.
Would it make sense to have the `value == UNSET_BYTE_BUFFER` check in the
`TxnCondition.Value` constructor? We'd find out earlier I guess.
In terms of whether we'd want to remove the duplicate checks in
`compareWithOperator()`, I'll leave it up to you. If I'm able to make it
private again when I finish the CQL integration, perhaps I'd remove them, but
I'm fine either way at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
