iamaleksey commented on code in PR #22:
URL: https://github.com/apache/cassandra-accord/pull/22#discussion_r1067047579
##########
accord-core/src/main/java/accord/primitives/Ballot.java:
##########
@@ -22,15 +22,35 @@
public class Ballot extends Timestamp
{
+ public static Ballot fromBits(long msb, long lsb, Id node)
+ {
+ return new Ballot(msb, lsb, node);
+ }
+
+ public static Ballot fromRaw(long epoch, long hlc, Id node)
+ {
+ return fromRaw(epoch, hlc, 0, node);
+ }
+
+ public static Ballot fromRaw(long epoch, long hlc, int flags, Id node)
+ {
+ return new Ballot(epoch, hlc, flags, node);
+ }
+
public static final Ballot ZERO = new Ballot(Timestamp.NONE);
public Ballot(Timestamp from)
{
super(from);
}
- public Ballot(long epoch, long real, int logical, Id node)
+ Ballot(long epoch, long hlc, int flags, Id node)
+ {
+ super(epoch, hlc, flags, node);
+ }
+
+ private Ballot(long msb, long lsb, Id node)
Review Comment:
OCD: give both bottom two constructors same visibility? public, private, or
package-private, doesn't matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
