isaacreath commented on code in PR #2066:
URL: https://github.com/apache/cassandra/pull/2066#discussion_r1067374212
##########
src/java/org/apache/cassandra/db/streaming/CassandraEntireSSTableStreamWriter.java:
##########
@@ -93,7 +93,7 @@ public void write(StreamingDataOutputPlus out) throws
IOException
long bytesWritten = out.writeFileToChannel(channel, limiter);
progress += bytesWritten;
- session.progress(sstable.descriptor.filenameFor(component),
ProgressInfo.Direction.OUT, bytesWritten, length);
+ session.progress(sstable.descriptor.filenameFor(component),
ProgressInfo.Direction.OUT, bytesWritten, bytesWritten, length);
Review Comment:
I think the first usage of `bytesWritten` may be incorrect (everywhere else
uses what is calculated as `progress` above). Doesn't have to block this ticket
because it's already done this way, but it might be worth looking at in the
future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
