dcapwell commented on code in PR #2066:
URL: https://github.com/apache/cassandra/pull/2066#discussion_r1067388084
##########
src/java/org/apache/cassandra/db/streaming/CassandraEntireSSTableStreamWriter.java:
##########
@@ -93,7 +93,7 @@ public void write(StreamingDataOutputPlus out) throws
IOException
long bytesWritten = out.writeFileToChannel(channel, limiter);
progress += bytesWritten;
- session.progress(sstable.descriptor.filenameFor(component),
ProgressInfo.Direction.OUT, bytesWritten, length);
+ session.progress(sstable.descriptor.filenameFor(component),
ProgressInfo.Direction.OUT, bytesWritten, bytesWritten, length);
Review Comment:
we spoke in Slack, the summary is:
There is the field `progress` that tracks all the bytes written regardless
of files, but `session.progress` is relative to the file. @isaacreath thought
that we should do
```
session.progress(sstable.descriptor.filenameFor(component),
ProgressInfo.Direction.OUT, progress, bytesWritten, length);
```
This was a misunderstanding and chatting about it cleared things up; we are
relative to the file so can't use `progress` in this context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
