adelapena commented on code in PR #2067:
URL: https://github.com/apache/cassandra/pull/2067#discussion_r1068002545
##########
src/java/org/apache/cassandra/locator/SimpleSeedProvider.java:
##########
@@ -62,6 +105,12 @@ public List<InetAddressAndPort> getSeeds()
logger.warn("Seed provider couldn't lookup host {}", host);
}
}
+
+ if (seeds.size() >= SEED_COUNT_WARN_THRESHOLD)
+ logger.warn("Seed provider returned more than {} seeds. " +
+ "A large seed list may impact effectiveness of the
third gossip round",
+ SEED_COUNT_WARN_THRESHOLD);
Review Comment:
I understand it would be an overkill to use a guardrail for this, given that
this isn't a limit for user actions but just a warning for admins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
