jacek-lewandowski commented on code in PR #2064: URL: https://github.com/apache/cassandra/pull/2064#discussion_r1072183800
########## src/java/org/apache/cassandra/utils/BloomFilterSerializer.java: ########## @@ -17,47 +17,66 @@ */ package org.apache.cassandra.utils; -import java.io.DataInput; import java.io.IOException; import java.io.InputStream; +import java.io.OutputStream; import org.apache.cassandra.db.TypeSizes; +import org.apache.cassandra.io.IGenericSerializer; +import org.apache.cassandra.io.util.DataInputPlus; import org.apache.cassandra.io.util.DataOutputPlus; import org.apache.cassandra.utils.obs.IBitSet; import org.apache.cassandra.utils.obs.OffHeapBitSet; -public final class BloomFilterSerializer +public final class BloomFilterSerializer<I extends InputStream & DataInputPlus, O extends OutputStream & DataOutputPlus> implements IGenericSerializer<BloomFilter, I, O> Review Comment: long story short, because `FileInputStreamPlus` is not a subclass of `DataInputStreamPlus` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
