jacek-lewandowski commented on code in PR #1488:
URL: https://github.com/apache/cassandra/pull/1488#discussion_r1082216848
##########
src/java/org/apache/cassandra/net/MessagingService.java:
##########
@@ -527,11 +530,17 @@ public Future<Void>
maybeReconnectWithNewIp(InetAddressAndPort address, InetAddr
*/
public void shutdown()
{
- shutdown(1L, MINUTES, true, true);
+ if (NON_GRACEFUL_SHUTDOWN)
+ // this branch is used in unit-tests when we really never restart
a node and shutting down means the end of test
+ shutdown(1L, MINUTES, false, true, false);
+ else
+ shutdown(1L, MINUTES, true, true, true);
}
- public void shutdown(long timeout, TimeUnit units, boolean
shutdownGracefully, boolean shutdownExecutors)
+ public void shutdown(long timeout, TimeUnit units, boolean
shutdownGracefully, boolean shutdownExecutors, boolean blocking)
Review Comment:
Yes, I agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
