smiklosovic commented on code in PR #1488:
URL: https://github.com/apache/cassandra/pull/1488#discussion_r1082367107
##########
src/java/org/apache/cassandra/net/MessagingService.java:
##########
@@ -233,6 +234,8 @@ public static int getVersionOrdinal(int version)
return ordinal;
}
+ public final static boolean NON_GRACEFUL_SHUTDOWN =
Boolean.getBoolean("cassandra.test.messagingService.nonGracefulShutdown");
Review Comment:
The patch we work on is gathering all properties, irrelevant what they are
for, in one place. I understand these are just test properties but having them
somewhere separately, for example, in test source, would mean that we would
start to reference test class in the prod code. Right? Not good. Having test
code referencing prod code where these test properties are is better.
I am not sure how to reply to your idea about `cassandra.test`. I think that
in general it is good idea to have them with that prefix, yes. Otherwise we are
not completely sure, at the first glance, if there is not any comment, what
that property is actually used for / upon.
In the long run, we would like to have all test properties with such prefix
(it is really messy right now) but the first task is to manage the current
"chaos" with having them scattered across all the source code. As of now,
nobody has a definitive answer what all properties we use ....
I think test properties with some value should be set as the very first
thing in the test class? So the defaults would be overridden (if desirable) by
a tester upon starting that test when this is `final static`. If the value of
that property is meant to be changed during the test then this needs to be
fixed on the code level to resolve that property dynamically as it is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
