jacek-lewandowski commented on code in PR #2064:
URL: https://github.com/apache/cassandra/pull/2064#discussion_r1082599640
##########
src/java/org/apache/cassandra/io/sstable/Descriptor.java:
##########
@@ -423,6 +425,19 @@ public boolean isCompatible()
return version.isCompatible();
}
+ public Set<Component> discoverComponents()
+ {
+ Set<Component.Type> knownTypes = Sets.difference(Component.TYPES,
Collections.singleton(Component.Type.CUSTOM));
+ Set<Component> components =
Sets.newHashSetWithExpectedSize(knownTypes.size());
+ for (Component.Type componentType : knownTypes)
+ {
+ Component component = new Component(componentType);
Review Comment:
I don't think I can do that because in that case when `new Component` was
called, the `singletons` field would not be initialized yet.
Given your other comments, we will probably go back to `Component` class
when making sstable format really pluggable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
