josh-mckenzie commented on code in PR #1488:
URL: https://github.com/apache/cassandra/pull/1488#discussion_r1084485809
##########
src/java/org/apache/cassandra/io/util/PathUtils.java:
##########
@@ -310,13 +312,39 @@ public static Throwable delete(Path file, Throwable
accumulate, @Nullable RateLi
return accumulate;
}
+ private static void deleteRecursiveUsingNixCommand(Path path, boolean
quietly)
Review Comment:
Well, fair, nobody wants delete to be _slow_. But the reason this method
exists is because on a specific platform it's significantly faster, and the
only way a future maintainer would know that is an anthropological dig w/JIRA
comments and descriptions to determine why something was changed. I'm fine
leaving the name as is, but commenting why this seemingly redundant
functionality was introduced would be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
