maedhroz commented on code in PR #2105:
URL: https://github.com/apache/cassandra/pull/2105#discussion_r1084635340
##########
src/java/org/apache/cassandra/cql3/restrictions/RestrictionSet.java:
##########
@@ -104,6 +104,17 @@ public List<ColumnMetadata> getColumnDefs()
{
return new ArrayList<>(restrictions.keySet());
}
+
+ @Override
+ public Collection<ColumnMetadata> getColumnDefinitions()
Review Comment:
I think the worry there (for performance) was what appeared to be a needless
defensive copy in `getColumnDefs()`. I didn't want to audit the 12 other
existing callers of `getColumnDefs()`. Certainly open to naming changes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
