jonmeredith commented on code in PR #2104:
URL: https://github.com/apache/cassandra/pull/2104#discussion_r1087996132


##########
src/java/org/apache/cassandra/streaming/StreamSession.java:
##########
@@ -694,8 +702,7 @@ public Future<?> onError(Throwable e)
             state(State.FAILED); // make sure subsequent error handling sees 
the session in a final state 
             channel.sendControlMessage(new 
SessionFailedMessage()).awaitUninterruptibly();
         }
-
-        return closeSession(State.FAILED);
+        return closeSession(State.FAILED, "Failed because of an unkown 
exception;\n" + Throwables.getStackTraceAsString(e));

Review Comment:
   I think it's just printing the stack trace, not any message reason. 
Including the stacktrace in the message seems like it would generate a lot of 
output and be hard to read, but perhaps that's worth it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to