jacek-lewandowski commented on code in PR #2064:
URL: https://github.com/apache/cassandra/pull/2064#discussion_r1090239389
##########
src/java/org/apache/cassandra/io/sstable/format/SSTableReader.java:
##########
@@ -1415,7 +1418,7 @@ public boolean
mayContainAssumingKeyIsInRange(DecoratedKey key)
protected static final class InstanceTidier implements Tidy
{
private final Descriptor descriptor;
- private final TableId tableId;
+ private final Owner owner;
Review Comment:
I don't know TBH. But since the owner is passed explicitly when the sstable
instance is built, I would find it quite weird that sstable could lost such
reference. Especially that the building code doesn't necessarily need to pass
an owner, it is allowed to pass null. This is just my gut feeling, and I'm not
strongly opposed to change that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
