blambov commented on code in PR #2118:
URL: https://github.com/apache/cassandra/pull/2118#discussion_r1093587398
##########
src/java/org/apache/cassandra/dht/IPartitioner.java:
##########
@@ -128,8 +128,9 @@ default Token getMaximumToken()
/**
* Abstract type that orders the same way as DecoratedKeys provided by
this partitioner.
* Used by secondary indices.
+ * @param baseType base type for PartitionerDefinedOrder
*/
- public AbstractType<?> partitionOrdering();
+ public AbstractType<?> partitionOrdering(AbstractType<?> baseType);
Review Comment:
> A workaround to keep the API compatibility, if needed, would be providing
a default implementation of the new `partitionOrdering(AbstractType)`, and
keeping the previous `partitionOrdering()` method.
This works for me. Would it need mailing list agreement too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
