adelapena commented on code in PR #2110:
URL: https://github.com/apache/cassandra/pull/2110#discussion_r1094759656
##########
src/java/org/apache/cassandra/schema/SchemaKeyspace.java:
##########
@@ -137,6 +139,11 @@ private SchemaKeyspace()
+ "kind text,"
+ "position int,"
+ "type text,"
+ + "mask_keyspace text,"
+ + "mask_name text,"
+ + "mask_argument_types frozen<list<text>>,"
+ + "mask_argument_values frozen<list<blob>>,"
+ + "mask_argument_nulls frozen<list<boolean>>," // arguments that
are null
Review Comment:
The schema produced by this will be rejected by Cassandra versions without
this patch. So this will break downgrades. This is ok if this lands in a major
(5.0), but not if it goes to a minor (4.2).
As an alternative, we can just put the masks on a separate table, this way:
https://github.com/adelapena/cassandra/commit/cc9983911c6a99954a1e6ef0aeffa8f439f9b888
That separate table for masks will just be ignored by older versions during
a downgrade. It replicates the primary key of `system_schema.columns`, which is
not ideal unless that's done for supporting downgrades. @blerer wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
