maedhroz commented on code in PR #2114:
URL: https://github.com/apache/cassandra/pull/2114#discussion_r1097894780
##########
build.xml:
##########
@@ -283,10 +286,21 @@
</fileset>
</path>
- <target name="_build-accord">
- <echo unless:set="env.ACCORD_LOCAL_DEV">building Accord, set
ACCORD_LOCAL_DEV environment variable to skip</echo>
- <exec unless:set="env.ACCORD_LOCAL_DEV"
executable=".build/include-accord.sh" dir="${basedir}" logError="true"
failonerror="true" failifexecutionfails="true" />
- <echo if:set="env.ACCORD_LOCAL_DEV">ACCORD_LOCAL_DEV environment
variable is set, skipping pull/install</echo>
+ <target name="_build-accord" depends="init">
+ <exec executable="${basedir}/accord/gradlew" dir="${basedir}/accord"
logError="true" failonerror="true" failifexecutionfails="true">
+ <!-- Need to call clean as a version change with a jar that didn't
have code changes will not procude a new jar with the new version... so need
clean to make sure build is stable -->
Review Comment:
```suggestion
<!-- Need to call clean as a version change with a jar that didn't
have code changes will not produce a new jar with the new version... so need
clean to make sure build is stable -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
