belliottsmith commented on code in PR #2144: URL: https://github.com/apache/cassandra/pull/2144#discussion_r1100729522
########## src/java/org/apache/cassandra/service/accord/AccordKeyspace.java: ########## @@ -96,21 +105,20 @@ import org.apache.cassandra.schema.UserFunctions; import org.apache.cassandra.schema.Views; import org.apache.cassandra.serializers.UUIDSerializer; -import org.apache.cassandra.service.accord.AccordCommandsForKey.SeriesKind; -import org.apache.cassandra.service.accord.api.PartitionKey; import org.apache.cassandra.service.accord.api.AccordRoutingKey; +import org.apache.cassandra.service.accord.api.PartitionKey; import org.apache.cassandra.service.accord.serializers.CommandSerializers; +import org.apache.cassandra.service.accord.serializers.CommandsForKeySerializer; import org.apache.cassandra.service.accord.serializers.DepsSerializer; import org.apache.cassandra.service.accord.serializers.KeySerializers; -import org.apache.cassandra.service.accord.store.StoredNavigableMap; -import org.apache.cassandra.service.accord.store.StoredSet; +import org.apache.cassandra.service.accord.serializers.ListenerSerializers; import org.apache.cassandra.service.accord.txn.TxnData; -import org.apache.cassandra.utils.ByteBufferUtil; import org.apache.cassandra.utils.Clock; import static java.lang.String.format; import static org.apache.cassandra.cql3.QueryProcessor.executeOnceInternal; Review Comment: We should probably use `executeInternal` to avoid parsing the query every time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
