bdeggleston commented on PR #33: URL: https://github.com/apache/cassandra-accord/pull/33#issuecomment-1423400891
> CommandsForKey has been woven throughout the API. This was excised for range transactions, and while I'm not sure if range transactions work right now, it is inconsistent with how their persistence is managed. I think this is quite easy to avoid, and permits us the flexibility to avoid using CommandsForKey when we have suitable caches. Yeah the range transactions patch that removed CommandsForKey landed pretty close to when the final rebase began and adapting the CFK changes in the immutable state patch ended up being more of a rebase kludge than a proper refactor. This was on my list of things to polish a bit, now that I’m more familiar with the the cfk changes. Just to be clear though, you’re referring to the reintroduction of cfk getters etc to the safe command store, not the changes to CommandsForKey itself? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
