adelapena commented on code in PR #2142:
URL: https://github.com/apache/cassandra/pull/2142#discussion_r1101435156
##########
src/java/org/apache/cassandra/db/virtual/VirtualTable.java:
##########
@@ -76,4 +76,15 @@ default String name()
* Truncates data from the underlying source, if supported.
*/
void truncate();
+
+ /**
+ * Tells whether {@code ALLOW FILTERING} is implicitly added to select
statement
+ * which requires it. Defaults to true.
+ *
+ * @return true if {@code ALLOW FILTERING} is implicitly added to select
statements when required, false otherwise.
+ */
+ default boolean allowFilteringImplicitly()
Review Comment:
Nit: I'd call it `allowsFilteringImplicitly`, or even just
`allowsFiltering`. As for the javadoc, we don't actually add `ALLOW FILTERING`
to the query, we just stop failing on its absence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
