ekaterinadimitrova2 commented on code in PR #2154: URL: https://github.com/apache/cassandra/pull/2154#discussion_r1103193909
########## test/conf/cassandra-murmur.yaml: ########## @@ -39,6 +39,6 @@ compaction_throughput: 0MiB/s row_cache_class_name: org.apache.cassandra.cache.OHCProvider row_cache_size: 16MiB user_defined_functions_enabled: true -scripted_user_defined_functions_enabled: true +scripted_user_defined_functions_enabled: false Review Comment: We can but I wasn't completely sure how things will go in the other ticket as this is only deprecated now in Config class. (And in general there is this tendancy to leave config in the Config class deprecated, maybe even forever? I hear different opinions) Also, wanted to be sure during testing we don't get sabotaged getting the value from somewhere else that I miss, so flipping at first to be sure they are disabled and fail sounded as a good first choice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
