jonmeredith commented on code in PR #2104:
URL: https://github.com/apache/cassandra/pull/2104#discussion_r1103321248
##########
src/java/org/apache/cassandra/streaming/StreamSession.java:
##########
@@ -694,8 +701,7 @@ public Future<?> onError(Throwable e)
state(State.FAILED); // make sure subsequent error handling sees
the session in a final state
channel.sendControlMessage(new
SessionFailedMessage()).awaitUninterruptibly();
}
-
- return closeSession(State.FAILED);
+ return closeSession(State.FAILED, "Failed because of an exception that
is not an EOF exception;\n" + Throwables.getStackTraceAsString(e));
Review Comment:
I should have been clearer with my original comment, I was saying that we
should include the name of the exception here - though I suppose you could work
it out by the call point if you went back at the source.
```
`"Failed because of " + e.getClass().getCanonicalName() + " exception ;\n" +
Throwables.getStackTraceAsString(e)`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
