adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1104862940
##########
src/java/org/apache/cassandra/db/rows/ArrayCell.java:
##########
@@ -34,19 +36,20 @@ public class ArrayCell extends AbstractCell<byte[]>
{
private static final long EMPTY_SIZE = ObjectSizes.measure(new
ArrayCell(ColumnMetadata.regularColumn("", "", "", ByteType.instance), 0L, 0,
0, EMPTY_BYTE_ARRAY, null));
+ // Careful: Adding vars here has an impact on memtable size
private final long timestamp;
private final int ttl;
- private final int localDeletionTime;
+ private final int localDeletionTimeGuavaUint;
private final byte[] value;
private final CellPath path;
- public ArrayCell(ColumnMetadata column, long timestamp, int ttl, int
localDeletionTime, byte[] value, CellPath path)
+ public ArrayCell(ColumnMetadata column, long timestamp, int ttl, long
localDeletionTime, byte[] value, CellPath path)
{
super(column);
this.timestamp = timestamp;
this.ttl = ttl;
- this.localDeletionTime = localDeletionTime;
+ this.localDeletionTimeGuavaUint =
Cell.deletionTimeLongToGuavaUint(localDeletionTime);
Review Comment:
```suggestion
this.localDeletionTimeGuavaUint =
deletionTimeLongToGuavaUint(localDeletionTime);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
