adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1107154459
##########
src/java/org/apache/cassandra/db/LivenessInfo.java:
##########
@@ -60,18 +60,33 @@ protected LivenessInfo(long timestamp)
this.timestamp = timestamp;
}
- public static LivenessInfo create(long timestamp, int nowInSec)
+ public static LivenessInfo create(long timestamp, long nowInSec)
{
return new LivenessInfo(timestamp);
}
- public static LivenessInfo expiring(long timestamp, int ttl, int nowInSec)
+ public static LivenessInfo expiring(long timestamp, int ttl, long nowInSec)
{
assert ttl != EXPIRED_LIVENESS_TTL;
return new ExpiringLivenessInfo(timestamp, ttl,
ExpirationDateOverflowHandling.computeLocalExpirationTime(nowInSec, ttl));
}
- public static LivenessInfo create(long timestamp, int ttl, int nowInSec)
+ // c14227 do not use. Special use to circumvent the overflow policy when
scrubbing
+ public static LivenessInfo expiring(long timestamp, int ttl, long
nowInSec, boolean applyOverflowPolicy)
+ {
+ assert ttl != EXPIRED_LIVENESS_TTL;
+ return new ExpiringLivenessInfo(timestamp, ttl, applyOverflowPolicy ?
ExpirationDateOverflowHandling.computeLocalExpirationTime(nowInSec, ttl) :
nowInSec);
+ }
+
+ // c14227 do not use. Special use to circumvent the overflow policy when
scrubbing
+ public static LivenessInfo create(long timestamp, int ttl, long nowInSec,
boolean applyOverflowPolicy)
Review Comment:
Can be `private`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
