belliottsmith commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1108360700
##########
test/unit/org/apache/cassandra/cql3/validation/entities/SecondaryIndexTest.java:
##########
@@ -1575,7 +1575,7 @@ private void
testIndexOnPartitionKeyInsertExpiringColumn(boolean flushBeforeUpda
flush();
execute("UPDATE %s USING TTL 1 SET b = 10 WHERE k1 = 1 AND k2 = 2");
- Thread.sleep(1000);
+ Thread.sleep(1500);
Review Comment:
Tests should be deterministic, and it's up to authors to make that happen.
In this case, probably the easiest thing to do is to execute both with a
provided timestamp and nowInSeconds, for which there are existing methods in
QueryProcessor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
