blambov commented on code in PR #2064:
URL: https://github.com/apache/cassandra/pull/2064#discussion_r1109546204
##########
test/unit/org/apache/cassandra/Util.java:
##########
@@ -1236,4 +1241,18 @@ public static void flush(TableViews view)
{
view.forceBlockingFlush(ColumnFamilyStore.FlushReason.UNIT_TESTS);
}
+
+ public static DataInputPlus.DataInputStreamPlus
createDataInputStreamPlus(InputStream in)
+ {
+ DataInputStreamPlusImpl impl = new DataInputStreamPlusImpl(in);
+ return Mockito.mock(DataInputPlus.DataInputStreamPlus.class, new
ForwardsInvocations(impl));
Review Comment:
Isn't it risky to always mock (i.e. track invocations), which can cause a
lot of overhead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
