adelapena commented on code in PR #2163: URL: https://github.com/apache/cassandra/pull/2163#discussion_r1110200639
########## .circleci/readme.md: ########## @@ -149,44 +154,37 @@ default medium config and Large containers. ## Updating the config For configuration changes meant to be permanent in the Apache repo you should never edit the `config.yml` file manually. Instead, you should edit the `config-2_1.yml` file and then Review Comment: +1 to renaming the file, even if it's only because I never remember where to put the hyphen and where the underscore in `config-2_1.yml`. Regarding the new name for the file, I'm not sure if calling it a template is clear enough, and we also refer to the FREE/PAID configs as templates. Maybe it's the main config file, or the manually-generated file? In CircleCI terminology, `config.yml` is the "expanded config" and `config-2_1.yml` is the "reusable config". For us, `config-2_1.yml` is the file that we manually edit, and `config.yml` is the one that we automatically generate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
