adelapena commented on code in PR #2110:
URL: https://github.com/apache/cassandra/pull/2110#discussion_r1114186324
##########
src/java/org/apache/cassandra/schema/SchemaKeyspace.java:
##########
@@ -137,6 +139,11 @@ private SchemaKeyspace()
+ "kind text,"
+ "position int,"
+ "type text,"
+ + "mask_keyspace text,"
+ + "mask_name text,"
+ + "mask_argument_types frozen<list<text>>,"
+ + "mask_argument_values frozen<list<blob>>,"
+ + "mask_argument_nulls frozen<list<boolean>>," // arguments that
are null
Review Comment:
In light of the current discussions about downgradability it might be
prudent to use a separate table for the masks, so the schema can be opened
after an aborted upgrade. Otherwise, the new columns on the table column would
fail at startup. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
