adelapena commented on code in PR #2125:
URL: https://github.com/apache/cassandra/pull/2125#discussion_r1115714276
##########
src/java/org/apache/cassandra/cql3/selection/Selector.java:
##########
@@ -443,14 +447,21 @@ private <V> ByteBuffer value(Cell<V> c)
}
/**
- * Return the value of the column with the specified index.
+ * Return the value of the column with the specified index. If the
column the value belongs to is masked with a
+ * {@link ColumnMask} and {@link #unmask} hasn't been specified, such
mask will be applied to the value.
*
* @param index the column index
- * @return the value of the column with the specified index
+ * @return the value of the column with the specified index, masked if
its column is masked
*/
public ByteBuffer getValue(int index)
{
- return values[index];
+ ByteBuffer value = values[index];
Review Comment:
Why would those changes be unnecessary? Note that `InputRow` collects the
same as before, and it's only the `InputRow#getValue` getter method what is
changed. The only caller of `InputRow#getValue` is `SimpleSelector`, which is
where we did the masking before. So things shouldn't change from the previous
state.
Indeed the wildcard query tests fail if we remove the call to
`TableMetadata#hasMaskedColumns` in
`SelectStatement.RawStatement#prepareSelection` that makes it go through
`wildcardWithGroupByOrMaskedColumns`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
