maedhroz commented on code in PR #2190:
URL: https://github.com/apache/cassandra/pull/2190#discussion_r1125164024
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -4397,6 +4397,11 @@ public static boolean getAccordTransactionsEnabled()
return conf.accord_transactions_enabled;
}
+ public static void setAccordTransactionsEnabled(boolean b)
+ {
+ conf.accord_transactions_enabled = b;
Review Comment:
nit: Does `accord_transactions_enabled` need to be volatile now? (I've seen
comments on the mailing list around this not actually being required, but I'm
not sure I understand. Is it that there are so many other locks held and
released around touching these values that they're bound to be visible within a
short time anyway?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
