dcapwell commented on code in PR #2190:
URL: https://github.com/apache/cassandra/pull/2190#discussion_r1128421336
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -226,7 +226,7 @@ public TxnData coordinate(Txn txn, ConsistencyLevel
consistencyLevel)
private static RuntimeException throwTimeout(Txn txn, ConsistencyLevel
consistencyLevel)
{
- throw txn.isWrite() ? new WriteTimeoutException(WriteType.TRANSACTION,
consistencyLevel, 0, 0)
+ throw txn.isWrite() ? new WriteTimeoutException(WriteType.CAS,
consistencyLevel, 0, 0)
Review Comment:
> wouldn't it be worth making it somehow dynamically adjust to the driver
version?
I would hope we do this similar to how we downgrade to v4 or use smaller
versions in internode... I would hope I provide `TRANSACTION` and there is some
cql3 driver sending logic that knows that it needs to "downgrade" and hide that
value...
Given that we wish to not change drivers for accord support, thought best to
leave this to another ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
