dcapwell commented on PR #2144: URL: https://github.com/apache/cassandra/pull/2144#issuecomment-1460522914
I am mostly cool with all the changes since last approval. I still have 2 concerns but think it is ok to merge while we try to figure out what happened; while running perf tests I hit 2 issues: many transactions depended on a PreAccepted one that never made progress, and 2 transactions depended on NotWitnessed transactions (150 and 260) but this was a single node test only I know burn tests have been running and no repo there yet, and once this patch rebases to pick up CASSANDRA-18299 I can rerun benchmarks to see if I can repo again... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
