adelapena commented on code in PR #2125:
URL: https://github.com/apache/cassandra/pull/2125#discussion_r1130925908
##########
src/java/org/apache/cassandra/cql3/statements/SelectStatement.java:
##########
@@ -1401,8 +1411,8 @@ private Comparator<List<ByteBuffer>>
getOrderingComparator(Selection selection,
if (!restrictions.keyIsInRelation())
return null;
- List<Integer> idToSort = new ArrayList<>(orderingColumns.size());
- List<Comparator<ByteBuffer>> sorters = new
ArrayList<>(orderingColumns.size());
+ List<Integer> idToSort = new
ArrayList<Integer>(orderingColumns.size());
Review Comment:
Actually, those pre-Java 7 generics are [on
trunk](https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java#L1400-L1401).
I updated them on CASSANDRA-18068, but I messed up during rebase. I've changed
them again to use the diamond operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
