dcapwell commented on code in PR #28:
URL: https://github.com/apache/cassandra-accord/pull/28#discussion_r1131818042


##########
accord-core/src/test/java/accord/impl/list/ListAgent.java:
##########
@@ -58,6 +58,7 @@ public void onInconsistentTimestamp(Command command, 
Timestamp prev, Timestamp n
     @Override
     public void onUncaughtException(Throwable t)
     {
+        if (t instanceof accord.coordinate.Timeout) return;

Review Comment:
   I don't like this but SPL sees it and now calls agent so had to do else we 
fail nearly every time... I feel like this is calling out that SPL should have 
different logic which would allow us to remove this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to