dcapwell commented on code in PR #30:
URL: https://github.com/apache/cassandra-accord/pull/30#discussion_r1133013195
##########
accord-core/src/main/java/accord/utils/RelationMultiMap.java:
##########
@@ -221,7 +221,7 @@ public T build()
{
sortedKeyIndexes = new int[keyCount];
sortedKeys = Arrays.copyOf(keys, keyCount);
- Arrays.sort(sortedKeys);
+ Arrays.sort(sortedKeys, adapter.keyComparator());
Review Comment:
I feel that there are more cases, these were just the cases needed to make
the test stable... I tried a patch to make this class typed to make sure we
are the proper `Comparable` but that patch got very large, so punted for this
work around... I do feel that range should be `Comparable<Range>` instead and
just offer a `compareToKey`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
