smiklosovic commented on code in PR #2212:
URL: https://github.com/apache/cassandra/pull/2212#discussion_r1133841928


##########
.build/cassandra-build-deps-template.xml:
##########
@@ -127,5 +127,9 @@
       <groupId>com.fasterxml.jackson.dataformat</groupId>
       <artifactId>jackson-dataformat-yaml</artifactId>
     </dependency>
+    <dependency>

Review Comment:
   This needs to be added because 
`org.apache.cassandra.simulator.debug.SelfReconcilingRandom` uses `import 
org.hsqldb.lib.IntKeyLongValueHashMap;` from this library. We were using this 
dependency already as it was among dependencies of Hadoop we removed in this 
patch so we need to cherry-pick this one only. Scope is `test`.
   
   We can dedicate separate ticket to removing this library as well. It is 
rather suspicious we depend on hsqldb even it is in test scope. However, this 
ticket should just track the removal of Hadoop as such.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to