aratno commented on code in PR #17:
URL: https://github.com/apache/cassandra-harry/pull/17#discussion_r1135946078
##########
harry-core/src/harry/core/Configuration.java:
##########
@@ -1122,26 +1112,61 @@ public static class
RandomPartitionValidatorConfiguration implements VisitorConf
{
public final int partition_count;
public final int queries;
- public final Configuration.ModelConfiguration modelConfiguration;
+ public final Configuration.ModelConfiguration model_configuration;
+ public final QueryLoggerConfiguration query_logger;
// TODO: make query selector configurable
@JsonCreator
public
RandomPartitionValidatorConfiguration(@JsonProperty("partition_count") int
partition_count,
@JsonProperty("queries_per_partition") int queries,
- @JsonProperty("model")
Configuration.ModelConfiguration model)
+ @JsonProperty("model")
Configuration.ModelConfiguration model,
+ @JsonProperty("logger")
QueryLoggerConfiguration query_logger)
{
this.partition_count = partition_count;
this.queries = queries;
- this.modelConfiguration = model;
+ this.model_configuration = model;
+ this.query_logger = QueryLogger.thisOrDefault(query_logger);
}
@Override
public Visitor make(Run run)
{
- return new RandomValidator(partition_count, queries, run,
modelConfiguration);
+ return new RandomValidator(partition_count, queries, run,
model_configuration, query_logger.make());
+ }
+ }
+
+ @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include =
JsonTypeInfo.As.WRAPPER_OBJECT)
+ public interface QueryLoggerConfiguration extends
QueryLogger.QueryLoggerFactory
Review Comment:
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
