jacek-lewandowski commented on code in PR #2015:
URL: https://github.com/apache/cassandra/pull/2015#discussion_r1136754442
##########
test/unit/org/apache/cassandra/db/compaction/CompactionsCQLTest.java:
##########
@@ -217,48 +204,47 @@ public void testSetLocalCompactionStrategy() throws
Throwable
{
createTable("CREATE TABLE %s (id text PRIMARY KEY)");
Map<String, String> localOptions = new HashMap<>();
- localOptions.put("class", "DateTieredCompactionStrategy");
+ localOptions.put("class", "SizeTieredCompactionStrategy");
getCurrentColumnFamilyStore().setCompactionParameters(localOptions);
-
assertTrue(verifyStrategies(getCurrentColumnFamilyStore().getCompactionStrategyManager(),
DateTieredCompactionStrategy.class));
+
assertTrue(verifyStrategies(getCurrentColumnFamilyStore().getCompactionStrategyManager(),
SizeTieredCompactionStrategy.class));
// Invalidate disk boundaries to ensure that boundary invalidation
will not cause the old strategy to be reloaded
getCurrentColumnFamilyStore().invalidateLocalRanges();
// altering something non-compaction related
execute("ALTER TABLE %s WITH gc_grace_seconds = 1000");
// should keep the local compaction strat
-
assertTrue(verifyStrategies(getCurrentColumnFamilyStore().getCompactionStrategyManager(),
DateTieredCompactionStrategy.class));
+
assertTrue(verifyStrategies(getCurrentColumnFamilyStore().getCompactionStrategyManager(),
SizeTieredCompactionStrategy.class));
// Alter keyspace replication settings to force compaction strategy
reload
execute("alter keyspace "+keyspace()+" with replication = { 'class' :
'SimpleStrategy', 'replication_factor' : 3 }");
// should keep the local compaction strat
-
assertTrue(verifyStrategies(getCurrentColumnFamilyStore().getCompactionStrategyManager(),
DateTieredCompactionStrategy.class));
+
assertTrue(verifyStrategies(getCurrentColumnFamilyStore().getCompactionStrategyManager(),
SizeTieredCompactionStrategy.class));
// altering a compaction option
- execute("ALTER TABLE %s WITH compaction =
{'class':'SizeTieredCompactionStrategy', 'min_threshold':3}");
+ execute("ALTER TABLE %s WITH compaction =
{'class':'LeveledCompactionStrategy'}");
Review Comment:
why changes from STCS to LCS ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
