Claudenw commented on code in PR #2196:
URL: https://github.com/apache/cassandra/pull/2196#discussion_r1136843047
##########
src/java/org/apache/cassandra/service/StorageProxy.java:
##########
@@ -2641,6 +2641,7 @@ public static Future<Void> submitHint(Mutation mutation,
EndpointsForToken targets,
AbstractWriteResponseHandler<IMutation> responseHandler)
{
+ targets = targets.filter(StorageProxy::shouldHint);
Review Comment:
If `targets` is empty then perhaps an `ImmediateFuture` future should be
returned rather than continuing with the construction of a regular future that
does nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
