smiklosovic commented on code in PR #2217:
URL: https://github.com/apache/cassandra/pull/2217#discussion_r1136935172
##########
src/java/org/apache/cassandra/cql3/statements/SelectStatement.java:
##########
@@ -1458,7 +1458,8 @@ private void checkNeedsFiltering(StatementRestrictions
restrictions) throws Inva
// We will potentially filter data if either:
// - Have more than one IndexExpression
// - Have no index expression and the row filter is not the
identity
- checkFalse(restrictions.needFiltering(),
StatementRestrictions.REQUIRES_ALLOW_FILTERING_MESSAGE);
+ if (restrictions.requiresAllowFilteringIfNotSpecified())
Review Comment:
yeah I was thinking about moving it there but I like how
`restrictions.needFiltering()` is isolated in what it does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
