aweisberg commented on code in PR #2220:
URL: https://github.com/apache/cassandra/pull/2220#discussion_r1140559617
##########
src/java/org/apache/cassandra/cql3/statements/UpdateStatement.java:
##########
@@ -237,12 +246,14 @@ public static class ParsedInsertJson extends
ModificationStatement.Parsed
{
private final Json.Raw jsonValue;
private final boolean defaultUnset;
+ private final boolean isForTxn;
- public ParsedInsertJson(QualifiedName name, Attributes.Raw attrs,
Json.Raw jsonValue, boolean defaultUnset, boolean ifNotExists, StatementSource
source)
+ public ParsedInsertJson(QualifiedName name, Attributes.Raw attrs,
Json.Raw jsonValue, boolean defaultUnset, boolean ifNotExists, StatementSource
source, boolean isForTxn)
{
super(name, StatementType.INSERT, attrs, null, ifNotExists, false,
source);
this.jsonValue = jsonValue;
this.defaultUnset = defaultUnset;
+ this.isForTxn = isForTxn;
Review Comment:
I think isForTxn is doesn't quite communicate that this is really for Accord
so even CAS is included not just `TransactionStatement`. In some contexts we
use lightweight transaction to describe CAS, but we don't always use this
version for the modification statement for CAS just when it is on Accord.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
