michaelsembwever commented on code in PR #2226:
URL: https://github.com/apache/cassandra/pull/2226#discussion_r1140759129


##########
src/java/org/apache/cassandra/utils/binlog/BinLog.java:
##########
@@ -170,6 +178,7 @@ public synchronized void stop() throws InterruptedException
 
         shouldContinue = false;
         sampleQueue.put(NO_OP);
+        BackgroundResourceReleaser.stop();

Review Comment:
   the `stop()` method did not exist previously
   
https://github.com/OpenHFT/Chronicle-Core/blob/chronicle-core-2.20.126/src/main/java/net/openhft/chronicle/core/io/BackgroundResourceReleaser.java
 
   
   (and failing to stop it previously did not cause the failures it does now)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to