ekaterinadimitrova2 commented on code in PR #2226:
URL: https://github.com/apache/cassandra/pull/2226#discussion_r1140787901


##########
.build/parent-pom-template.xml:
##########
@@ -705,7 +756,7 @@
       <dependency>
         <groupId>net.openhft</groupId>
         <artifactId>chronicle-queue</artifactId>
-        <version>5.20.123</version>

Review Comment:
   And those latest versions still correspond to specific BOM number, probably 
latest and I see in the past we were adding those looking at a BOM as my 
understanding is that the versions of the different dependencies which are 
listed in a BOM have been integrated and tested to work together.
   I was looking into this one - 
https://mvnrepository.com/artifact/net.openhft/chronicle-bom/2.23.137
   Then I also realized that we do not use the latest ea release (as we see we 
do with posix) but the previous one
   https://mvnrepository.com/artifact/net.openhft/chronicle-queue
   
   At first I thought you do not want to use ea version, but then you used for 
posix?
   
   I think adding the BOM number in a comment reminds people not to update 
separate dependency when it is known that some should be upgraded together to 
tested compatible versions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to