dcapwell commented on code in PR #2133:
URL: https://github.com/apache/cassandra/pull/2133#discussion_r1146462876
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -80,45 +82,54 @@ public static Set<String> splitCommaDelimited(String src)
public String authorizer;
public String role_manager;
public String network_authorizer;
- @Replaces(oldName = "permissions_validity_in_ms", converter =
Converters.MILLIS_DURATION_INT, deprecated = true)
- public volatile DurationSpec.IntMillisecondsBound permissions_validity =
new DurationSpec.IntMillisecondsBound("2s");
- public volatile int permissions_cache_max_entries = 1000;
- @Replaces(oldName = "permissions_update_interval_in_ms", converter =
Converters.MILLIS_CUSTOM_DURATION, deprecated = true)
- public volatile DurationSpec.IntMillisecondsBound
permissions_update_interval = null;
- public volatile boolean permissions_cache_active_update = false;
- @Replaces(oldName = "roles_validity_in_ms", converter =
Converters.MILLIS_DURATION_INT, deprecated = true)
- public volatile DurationSpec.IntMillisecondsBound roles_validity = new
DurationSpec.IntMillisecondsBound("2s");
- public volatile int roles_cache_max_entries = 1000;
- @Replaces(oldName = "roles_update_interval_in_ms", converter =
Converters.MILLIS_CUSTOM_DURATION, deprecated = true)
- public volatile DurationSpec.IntMillisecondsBound roles_update_interval =
null;
- public volatile boolean roles_cache_active_update = false;
- @Replaces(oldName = "credentials_validity_in_ms", converter =
Converters.MILLIS_DURATION_INT, deprecated = true)
- public volatile DurationSpec.IntMillisecondsBound credentials_validity =
new DurationSpec.IntMillisecondsBound("2s");
- public volatile int credentials_cache_max_entries = 1000;
- @Replaces(oldName = "credentials_update_interval_in_ms", converter =
Converters.MILLIS_CUSTOM_DURATION, deprecated = true)
- public volatile DurationSpec.IntMillisecondsBound
credentials_update_interval = null;
- public volatile boolean credentials_cache_active_update = false;
+ @Mutable @Replaces(oldName = "permissions_validity_in_ms", converter =
Converters.MILLIS_DURATION_INT, deprecated = true)
Review Comment:
by putting `@Mutable` on the same line as `@Replaces` this diff gets hard to
review as I have to check every character in `@Replaces` to make sure nothing
changed... if you keep then in different lines the diff is much cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
