jacek-lewandowski commented on code in PR #2233:
URL: https://github.com/apache/cassandra/pull/2233#discussion_r1148953867
##########
test/unit/org/apache/cassandra/io/sstable/keycache/KeyCacheTest.java:
##########
@@ -396,7 +395,6 @@ public void testKeyCacheLoadTwoTablesTime() throws Exception
// be zero after load.
assertKeyCacheSize(numberOfRows, KEYSPACE1, columnFamily1);
assertKeyCacheSize(numberOfRows, KEYSPACE2, columnFamily2);
- assertEquals(sstableImplCachesKeys ? numberOfRows * tables.size() : 0,
CacheService.instance.keyCache.size());
Review Comment:
Because it asserts the global cache size which is out of control of this
test. The test only controls the cache for the `KEYSPACE1` and `KEYSPACE2`, and
when something gets written to the cache because of say system keyspace
read/update, the test will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
