dcapwell commented on code in PR #2241:
URL: https://github.com/apache/cassandra/pull/2241#discussion_r1149599401
##########
src/java/org/apache/cassandra/service/accord/serializers/ApplySerializers.java:
##########
@@ -52,7 +50,7 @@ public Apply deserializeBody(DataInputPlus in, int version,
TxnId txnId, Partial
CommandSerializers.timestamp.deserialize(in, version),
DepsSerializer.partialDeps.deserialize(in, version),
CommandSerializers.writes.deserialize(in, version),
-
TxnData.serializer.deserialize(in, version));
+ null);
Review Comment:
so `Apply` only touches this by passing it to
`accord.local.SafeCommand#preapplied`, which calls
`accord.local.Command.Executed#executed(accord.local.CommonAttributes,
accord.local.SaveStatus, accord.primitives.Timestamp, accord.primitives.Ballot,
accord.primitives.Ballot, accord.local.Command.WaitingOn,
accord.primitives.Writes, accord.api.Result)`... Given the fact that this case
maps to `Result.APPLIED` later on I think its fine to drop, internally we can
still pass `Result.APPLIED` in
@belliottsmith thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
