Mmuzaf commented on code in PR #2178:
URL: https://github.com/apache/cassandra/pull/2178#discussion_r1155357680
##########
test/burn/org/apache/cassandra/utils/LongBTreeTest.java:
##########
@@ -785,7 +784,7 @@ public void testBatchesSmallOverlappingRange() throws
ExecutionException, Interr
@Test
public void testIndividualInsertsMediumSparseRange() throws
ExecutionException, InterruptedException
{
- testInsertions(randomSeed(), perThreadTrees / 10, 500, 10, 1, true);
+ testInsertions(randomSeed(), 500, 10, 1, true);
Review Comment:
Correct, I think we can safely increase the number of local runs for
`testLargeBatchesLargeRange`, and `testIndividualInsertsMediumSparseRange`
while still maintaining a reasonable execution time for the LongBTreeTest as a
whole.
For the tests that fire `testInsertions` with parameters the main concern we
have is - we perform different numbers of test attempts to check tree
insertions for variations of ranges and batches, but the same equal number of
`tests` should be used for all of them. I think `perThreadTrees * threads` is
the better choice for us since increasing the `perThreadTrees` (for
`testInsertions` it's not exactly trees per thread as it says, it's just a
multiplier) will give us the ability to find patterns e.g. for a heap
consumption during a particular run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
