jrwest commented on code in PR #2246:
URL: https://github.com/apache/cassandra/pull/2246#discussion_r1157485275
##########
src/java/org/apache/cassandra/config/GuardrailsOptions.java:
##########
@@ -835,6 +913,18 @@ private static void validateMaxRFThreshold(int warn, int
fail)
fail,
DatabaseDescriptor.getDefaultKeyspaceRF()));
}
+
+ public static void
validateTimestampThreshold(DurationSpec.LongMicrosecondsBound warn,
+
DurationSpec.LongMicrosecondsBound fail,
+ String name)
+ {
+ // this function is used for both upper and lower thresholds because
lower threshold is relative
+ // despite using MinThreshold we still want the warn threshold to be
less than or equal to
+ // the fail threshold.
+ validateMaxLongThreshold(warn.toMicroseconds(), fail.toMicroseconds(),
+ "timestamp_" + name + "_bound", true);
Review Comment:
will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
