dcapwell commented on code in PR #2258:
URL: https://github.com/apache/cassandra/pull/2258#discussion_r1157521084
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -137,7 +139,9 @@ private AccordService()
this.messageSink = new AccordMessageSink();
this.configService = new AccordConfigurationService(localId);
this.scheduler = new AccordScheduler();
+ this.config = new
AccordConfig(DatabaseDescriptor.getAccordSchedulerDelayInMS());
Review Comment:
this pattern isn't something we can maintain; every new config comes with a
massive burden to update this constructor; IMO we should push this logic into
the YAML layer
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -596,6 +596,7 @@ public MemtableOptions()
public volatile boolean use_statements_enabled = true;
public boolean accord_transactions_enabled = false;
+ public long accord_scheduler_delay_in_ms = 200L;
Review Comment:
agree with this comment, `DurationSpec` (or one of the ones that limit the
domain) is what we should do; `in_ms` should be avoided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
